clintropolis commented on code in PR #12828:
URL: https://github.com/apache/druid/pull/12828#discussion_r931668368
##########
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/AvroFlattenerMaker.java:
##########
@@ -173,6 +175,20 @@ private Object transformValue(final Object field)
} else {
return ((GenericFixed) field).bytes();
}
+ } else if (field instanceof Map) {
Review Comment:
I wonder if this should use like `if (avroJsonProvider.isArray(field)) ...`
and`if (avroJsonProvider.isMap(field)) ... `
There are also methods like `avroJsonProvider.length`,
`avroJsonProvider.getArrayIndex`, `avroJsonProvider.getPropertyKeys`,
`avroJsonProvider.getMapValue` etc. which could be used to extract stuff,
though the array one doesn't seem that useful since it just handles `List`
anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
