tejaswini-imply opened a new pull request, #12852: URL: https://github.com/apache/druid/pull/12852
### Description The `FiniteFirehoseFactory` and `InputRowParser` classes were deprecated in 0.17.0 (https://github.com/apache/druid/pull/8823) in favor of `InputSource` & `InputFormat`. This PR removes the `FiniteFirehoseFactory` and all its implementations along with classes solely used by them like `Fetcher` (Used by `PrefetchableTextFilesFirehoseFactory`). Refactors classes including tests using `FiniteFirehoseFactory` to use `InputSource` instead. Removing `InputRowParser` may not be as trivial as many classes that aren't deprecated depends on it (with no alternatives), like `EventReceiverFirehoseFactory`. Hence `FireHoseFactory`, `EventReceiverFirehoseFactory`, and `Firehose` are marked deprecated. **Discussion thread:** https://lists.apache.org/thread/lq5846jy7j4kf6r379cy4gpgqzdkfsf3 <hr/> #### Fixed the bug in `AbstractParallelIndexSupervisorTaskTest#compareTaskReports(..)` Indexing Task tests assert generated reports are as expected using `compareTaskReports(..)`. This becomes flaky in the case of Sequential Index Task since the generated `movingAverages` field in reports varies with task execution time. This PR modifies the method to skip this field. #### Renamed the class `TestRealtimeTask` to `TestIndexTask` Only `RemoteTaskRunnerTest` & `WorkerTaskMonitorTest` uses `RealtimeTask` currently. Modifying the name to `TestIndexTask` and implementing `IndexTask` (to use `InputSource` instead of `FirehoseFactory`) shouldn't affect both tests as they're simply testing `RemoteTaskRunner` & `WorkerTaskMonitor` functionalities, and they are task agnostic. #### Assumption made for `SamplerResource`: `/druid/indexer/v1/sampler` API receives `SamplerSpec`, and in the case of Seekable stream, it expects to contain non-null `InputFormat` with this PR. Verified that the current code or different ingestions on the console aren't sending null `InputFormat` in the spec. <hr> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
