abhishekagarwal87 commented on code in PR #12852:
URL: https://github.com/apache/druid/pull/12852#discussion_r939947073
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSamplerSpec.java:
##########
@@ -86,140 +69,25 @@ public SeekableStreamSamplerSpec(
public SamplerResponse sample()
{
final InputSource inputSource;
- final InputFormat inputFormat;
- if (dataSchema.getParser() != null) {
Review Comment:
this will still be needed till the time we can remove the `parser` related
code as well. I suggest that we keep the adapters around for now. We could
refactor the adapters such that we can still get rid of all the *firehose*
code. Just enough so that people using the parser can still use the sampler.
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSamplerSpec.java:
##########
@@ -77,6 +59,7 @@ public SeekableStreamSamplerSpec(
{
this.dataSchema = Preconditions.checkNotNull(ingestionSpec, "[spec] is
required").getDataSchema();
this.ioConfig = Preconditions.checkNotNull(ingestionSpec.getIoConfig(),
"[spec.ioConfig] is required");
+ this.inputFormat = Preconditions.checkNotNull(ioConfig.getInputFormat(),
"[spec.ioConfig.inputFormat] is required");
Review Comment:
I don't think we can do this yet. I have seen `parser` still being used by
folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
