clintropolis opened a new pull request, #12873: URL: https://github.com/apache/druid/pull/12873
### Description This PR fixes an issue with `JSONFlattenerMaker` leaking Jackson `JsonNode` types into `InputRow`, similar to what is going on in #12828. Handling for boolean and binary `JsonNode` types has been added to now return them as `Boolean` and `byte[]`, and now by default we will return a String value by calling `asText`, which should return something at least for all value nodes. Binary is probably not necessary as it is a Jackson thing that I think we'd be unlikely to see on input data, and in my tests with `byte[]` the values ended up as base64 strings in `TextNode` but I added it just in case. I also adjusted the `valueConversionFunction` into the implementation of `finalizeConversionForMap`, which is used when converting nested data rows to plain java maps for the sampler, though this change was less necessary I think because nothing really tries to process these directly they just get serialized in the sampler response. <hr> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
