gianm commented on code in PR #12873:
URL: https://github.com/apache/druid/pull/12873#discussion_r940710667
##########
core/src/main/java/org/apache/druid/java/util/common/parsers/JSONFlattenerMaker.java:
##########
@@ -143,11 +143,19 @@ private Object convertJsonNode(JsonNode val)
return charsetFix(val.asText());
}
+ if (val.isBoolean()) {
+ return val.asBoolean();
+ }
+
+ if (val.isBinary() && val instanceof BinaryNode) {
+ return ((BinaryNode) val).binaryValue();
Review Comment:
Hmm. Hard to have an opinion on what's best without knowing when (if ever)
this code path will get triggered. I just checked if it will get triggered for
regular JSON deserialization, and it doesn't seem like it does, so I'm not
worried about that anymore. Given that it's not going to happen for regular
JSON deserialization, I think the code you have here in the patch is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
