abhishekagarwal87 commented on code in PR #12867:
URL: https://github.com/apache/druid/pull/12867#discussion_r945500026
##########
services/src/test/java/org/apache/druid/server/AsyncQueryForwardingServletTest.java:
##########
@@ -568,6 +595,18 @@ protected void doService(
servlet.service(requestMock, null);
+ // NPE is expected since the listener's onComplete calls the parent class'
onComplete which fails due to
Review Comment:
Sorry for the late reply. Changes LGTM. Though we should remove the
assertion on NPE and just catch/ignore it. Since we are not really verifying
the NPE itself. We are getting NPE because of the way, the test is written and
not something that code does intentionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
