rohangarg commented on code in PR #12867:
URL: https://github.com/apache/druid/pull/12867#discussion_r959287850
##########
processing/src/test/java/org/apache/druid/query/DefaultQueryMetricsTest.java:
##########
@@ -67,6 +67,7 @@ public void testDefaultQueryMetricsQuery()
.build();
queryMetrics.query(query);
queryMetrics.reportQueryTime(0).emit(serviceEmitter);
+ queryMetrics.sqlQueryId("dummy"); // done just to pacify the code coverage
tool
Review Comment:
The code was added just to make the code coverage tool pass - the actual
verification can't be done because we have a no-op implementation for
`sqlQuery(String)` in the default metrics. I've updated the comment to be more
clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
