rohangarg commented on issue #12912: URL: https://github.com/apache/druid/issues/12912#issuecomment-1219580705
Thanks @FrankChen021 and @BartMiki for the thorough discussion. I have a few more points related to discussions : 1. Regarding performance, I think we can check once the time taken for old vs new approach to prepare the event to see we're not adding a lot of time in absolute terms atleast. 2. Regarding the problem for compatibility arising b/w serializing using annotation vs using `asMap` method and then serializing, it seems like that should be solved. Otherwise, the kind of JSON created for the same event object would differ according to the implementation of the `Emitter` as it is happening now. We could call out the incompat in release notes if needed. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
