BartMiki commented on issue #12912: URL: https://github.com/apache/druid/issues/12912#issuecomment-1219705653
@rohangarg regarding your points: 1. Do you have any tips how to measure that? Any recommended profilers? Maybe just a unit test per serialization method that runs serialization in a loop 100k times? 2. Current fix is compatible with previous output so there is no need for `incompat`. Actually it is interesting issue in general, because what is **the** method for generating output for the event? What is recommended by the Druid? Serialize Event with Jackson or with `.toMap`? To `.toMap` is part of Event which seems to be default, but many core Druid emitters just use Jackson on the Event. If somebody implements new emitter what they would default to? Maybe that should be included in the docs? To be honest I don't have a solution for that at this moment. Maybe we should introduce something like `EventToXSerializer` interfaces where `X` is format name. Then we can also provide default implementations, like `DefaultObjectMapper` is provided. What do you think? But that should be part of a new issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
