clintropolis commented on code in PR #12914:
URL: https://github.com/apache/druid/pull/12914#discussion_r953256089
##########
core/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -429,18 +443,15 @@ public static ExprEval ofType(@Nullable ExpressionType
type, @Nullable Object va
case STRING:
// not all who claim to be "STRING" are always a String, prepare
ourselves...
if (value instanceof String[]) {
- return new ArrayExprEval(ExpressionType.STRING_ARRAY, (String[])
value);
+ return new ArrayExprEval(ExpressionType.STRING_ARRAY,
Arrays.stream((String[]) value).toArray());
Review Comment:
good call, looking around there are quite a few usages of steam in array
stuffs, should I try to fix them all up in this PR or do as a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
