gianm commented on code in PR #12914:
URL: https://github.com/apache/druid/pull/12914#discussion_r953946774
##########
core/src/main/java/org/apache/druid/segment/column/ColumnType.java:
##########
@@ -26,18 +26,71 @@
import javax.annotation.Nullable;
+/**
+ * Native Druid types.
+ *
+ * @see TypeSignature
+ */
@JsonSerialize(using = ToStringSerializer.class)
public class ColumnType extends BaseTypeSignature<ValueType>
{
+ /**
+ * Druid string type. Values will be represented as {@link String} or {@link
java.util.List<String>} in the case
+ * of multi-value string columns. {@link ColumnType} has insufficient
information to distinguish between single
+ * and multi-value strings, this requires a type 'ColumnCapabilities' which
is available at a higher layer.
Review Comment:
> so disruptive i should probably give up hope that it will ever happen
There's always the old "do it during a quiet week" strategy 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
