zemin-piao commented on PR #12950: URL: https://github.com/apache/druid/pull/12950#issuecomment-1228209485
> > seems to me that it would make most sense to change behavior of existing config to your proposed behavior of hiddenPropertiesContain. The existing behavior should still match and exclude exact matches so clusters who leverage the config already won't see a difference on upgrade. This way there is only one configuration to manage. Unless I'm missing some issue that this would introduce? > > also, if this config is still not documented as the issue states, we should add the config to documentation for clarity. > > Indeed using one field approach is elegant and users don't need to remember many properties. If we directly adjust the behavior for `hiddenProperties` field, upgrading won't be a problem. Regarding backward compatibility, there is only one scenario where someone sets the property to ['pwd', 'key'], and after downgrading this won't work. For this scenario, should I include in the documentation? Or any other advices on this point? Already put a note at the index.md regarding the change of behavior on this property -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
