rash67 commented on code in PR #12879: URL: https://github.com/apache/druid/pull/12879#discussion_r957811859
########## processing/src/test/java/org/apache/druid/segment/serde/cell/CellWriterTest.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment.serde.cell; + +import org.apache.druid.segment.writeout.OnHeapMemorySegmentWriteOutMedium; + +public class CellWriterTest extends BytesReadWriteTestBase Review Comment: the CellWriter test tests both read and writer. it should be named as such. The same for BlockCompressPayloadWriter test... they cycle through a set of input byte[], and verify they can read the same bytes out in various cases, and test for sizes as well. the idioms for how to use the classes are in ByteWriterTestHelper and PayloadWriterValidationFunctionBuilder and CellReaderValidationFunctionBuilder. let me think about how to do this. the whole point of the base test was to avoid the fact that both the CellReader/Writer and BlockCompressedPayloadReader/Writer both read/write byte[]. The latter just requires you to manage the "index" of positions yourself. The two classes' APIs are so similar that leveraging the base was essential i could have a test file for each that showed a single use case perhaps? discuss in sync, I see your point, though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
