FrankChen021 commented on code in PR #12995:
URL: https://github.com/apache/druid/pull/12995#discussion_r958185890
##########
core/src/main/java/org/apache/druid/math/expr/vector/VectorProcessors.java:
##########
@@ -53,11 +53,17 @@ public static <T> ExprVectorProcessor<T>
makeSymmetricalProcessor(
{
final ExpressionType leftType = left.getOutputType(inspector);
+ // if type is null, it means the input is all nulls
if (leftType == null) {
return right.buildVectorized(inspector);
}
- Preconditions.checkArgument(inspector.areSameTypes(left, right));
+ Preconditions.checkArgument(
+ inspector.areSameTypes(left, right),
+ "%s and %s are not the same type",
Review Comment:
Can we print the type name of left and right in the error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
