capistrant commented on issue #12999:
URL: https://github.com/apache/druid/issues/12999#issuecomment-1232163768

   One way I could see this happening is if 
[this](https://github.com/apache/druid/blob/0.22.2/server/src/main/java/org/apache/druid/server/coordination/ChangeRequestHistory.java#L80)
 was called with an empty list. The only place I can tell that this would even 
be possible is 
[here](https://github.com/apache/druid/blob/0.22.2/server/src/main/java/org/apache/druid/server/coordination/BatchDataSegmentAnnouncer.java#L236)...
 but that should only be running during bootstrap and I have confirmed in my 
logs that I see the is finished log for the background announcer that runs 
during startup.
   
   Either way, I wonder if it makes sense to put a conditional in place to only 
clear the futures if that first link gets called with a list of non-zero length 
to prevent resolving the futures when the counter hasn't incremented


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to