paul-rogers commented on PR #13074: URL: https://github.com/apache/druid/pull/13074#issuecomment-1248790959
This is great! One general suggestion: provide an overview, in a `README.md` file, of the general design of the framework. By this I mean, what is being tested, what is simulated, and how the tests work. What I think I learned from looking at the code is: * We simulate the cluster by responding to command set from the coordinator. * We wrap the algorithm part of the coordinator in a "fixture" that we invoke from tests. * We verify results by looking at the state of the simulated nodes. It seems that the tests don't cover the dynamic aspects: load, the threads which decided when to fire off the control tasks in the coordinator, latencies, etc. It is fine to omit these, they are another level of complexity we could add once the basics work. Still, would be good to state which bits of the code this framework targets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
