LakshSingla commented on code in PR #13062:
URL: https://github.com/apache/druid/pull/13062#discussion_r972641028
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/DurableStorageOutputChannelFactory.java:
##########
@@ -112,31 +132,52 @@ public OutputChannel openNilChannel(int partitionNumber)
throw new ISE(
e,
"Unable to create empty remote output of workerTask[%s] stage[%d]
partition[%d]",
- workerTaskId,
+ workerNumber,
stageNumber,
partitionNumber
);
}
}
+ public void markAsSuccess(int partitionNumber) throws IOException
+ {
+ String oldPath = getPartitionOutputFileNameForTask(controllerTaskId,
workerNumber, stageNumber, partitionNumber, taskId);
+ storageConnector.moveFile(oldPath, StringUtils.format("%s%s", oldPath,
SUCCESSFUL_SUFFIX));
Review Comment:
Any alternatives for the S3 client? The current implementation has copy and
delete in S3. I didn't find a rename operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
