LakshSingla commented on code in PR #13062:
URL: https://github.com/apache/druid/pull/13062#discussion_r973871394
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/shuffle/DurableStorageInputChannelFactory.java:
##########
@@ -112,11 +119,33 @@ public ReadableFrameChannel openChannel(StageId stageId,
int workerNumber, int p
catch (Exception e) {
throw new IOE(
e,
- "Could not find remote output of worker task[%s] stage[%d]
partition[%d]",
- workerTaskId,
+ "Could not find remote output of worker task[%d] stage[%d]
partition[%d]",
+ workerNumber,
stageId.getStageNumber(),
partitionNumber
);
}
}
+
+ @Nullable
+ public String findSuccessfulPartitionOutput(
+ final String controllerTaskId,
+ final int workerNo,
+ final int stageNumber,
+ final int partitionNumber
+ ) throws IOException
+ {
+ List<String> fileNames = storageConnector.lsFiles(
+ DurableStorageOutputChannelFactory.getPartitionOutputsFolderName(
+ controllerTaskId,
+ workerNo,
+ stageNumber,
+ partitionNumber
+ )
+ );
+ Optional<String> maybeFileName = fileNames.stream()
Review Comment:
Thanks! As per your original suggestions, I like the time-based approach.
Another one that I can think of is picking up the first file in alphabetically
sorted order.
If we are using one of the above methods, then I see no inherent benefits in
using the controller to figure out the file in case of a tiebreaker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
