kfaraz commented on code in PR #12992:
URL: https://github.com/apache/druid/pull/12992#discussion_r973102527
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/QueryResultVerifier.java:
##########
@@ -19,13 +19,19 @@
package org.apache.druid.testing.utils;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.java.util.common.logger.Logger;
+
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
public class QueryResultVerifier
{
- public static boolean compareResults(
+ private static final Logger LOG = new Logger(QueryResultVerifier.class);
+
+ public static Optional<String> compareResults(
Review Comment:
Yes, within the response object, you may choose to maintain a single String
that represents the message. So while `getMessage()` would simply return that
message, `isSuccess()` could do a null check on it.
I would still prefer having a separate `success` flag as you might later
want to include a message even in cases of success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
