LakshSingla commented on code in PR #12992:
URL: https://github.com/apache/druid/pull/12992#discussion_r973825160
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/QueryResultVerifier.java:
##########
@@ -19,13 +19,19 @@
package org.apache.druid.testing.utils;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.java.util.common.logger.Logger;
+
import java.util.Iterator;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
public class QueryResultVerifier
{
- public static boolean compareResults(
+ private static final Logger LOG = new Logger(QueryResultVerifier.class);
+
+ public static Optional<String> compareResults(
Review Comment:
I would defer against the suggestion of
`QueryResultVerifier.assertEqual(...);` because the helper is not going to do
assertions based on the result. This is because the same method is utilized in
`ITQueryRetryTestOnMissingSegments.java` which depending on a flag fails or
drops the mismatch in the rows. Therefore one way would be to create a separate
method that helps perform the Assertions. But since this is not required in
several places, I haven't created a such method.
Good point regarding the test case in the planner. That would certainly be
a cleaner and easier approach to add the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
