zachjsh commented on code in PR #13089:
URL: https://github.com/apache/druid/pull/13089#discussion_r977963559
##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -85,6 +106,8 @@ public JsonInputFormat(
objectMapper.configure(feature, entry.getValue());
}
this.lineSplittable = lineSplittable;
+ this.assumeNewlineDelimited = assumeNewlineDelimited != null &&
assumeNewlineDelimited;
+ this.useJsonNodeReader = useJsonNodeReader != null && useJsonNodeReader;
Review Comment:
The description for this property above seems to indicate that it should be
used for non-newline delimited JSON. Would `assumeNewLineDelimted` true
interfere with this / should this be forced to false if `assumeNewLineDelimted`
is true
##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -85,6 +106,8 @@ public JsonInputFormat(
objectMapper.configure(feature, entry.getValue());
}
this.lineSplittable = lineSplittable;
+ this.assumeNewlineDelimited = assumeNewlineDelimited != null &&
assumeNewlineDelimited;
+ this.useJsonNodeReader = useJsonNodeReader != null && useJsonNodeReader;
Review Comment:
The description for this property above seems to indicate that it should be
used for non-newline delimited JSON. Would `assumeNewLineDelimted` true
interfere with this / should this be forced to false if `assumeNewLineDelimted`
is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
