zachjsh commented on code in PR #13089:
URL: https://github.com/apache/druid/pull/13089#discussion_r977968984
##########
core/src/main/java/org/apache/druid/data/input/impl/JsonInputFormat.java:
##########
@@ -109,9 +144,13 @@ public boolean isSplittable()
@Override
public InputEntityReader createReader(InputRowSchema inputRowSchema,
InputEntity source, File temporaryDirectory)
{
- return this.lineSplittable ?
- new JsonLineReader(inputRowSchema, source, getFlattenSpec(),
objectMapper, keepNullColumns) :
- new JsonReader(inputRowSchema, source, getFlattenSpec(),
objectMapper, keepNullColumns);
+ if (this.lineSplittable || this.assumeNewlineDelimited) {
Review Comment:
When would `lineSplitable` be false, but the the data is actually
newLineDelimited? Does this situation arise when you have a batch of new line
delimited json events being ingested at one time, for example?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
