panhongan commented on code in PR #11296:
URL: https://github.com/apache/druid/pull/11296#discussion_r979143762


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTaskClient.java:
##########
@@ -131,7 +137,7 @@ public Map<PartitionIdType, SequenceOffsetType> pause(final 
String id)
       } else if (responseStatus.equals(HttpResponseStatus.ACCEPTED)) {
         // The task received the pause request, but its status hasn't been 
changed yet.
         final RetryPolicy retryPolicy = newRetryPolicy();
-        while (true) {
+        while (pausingTaskFutureMap.getOrDefault(id, 
DEFAULT_TASK_PAUSE_CONTROL_INFO).isRunning()) {

Review Comment:
   pausingTaskFutureMap.containsKey(id) can't work.
   because if call `pause(id)`, id is not in `pausingTaskFutureMap`, so will 
return directly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to