panhongan commented on code in PR #11296:
URL: https://github.com/apache/druid/pull/11296#discussion_r979179496
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -2824,60 +2824,81 @@ private void checkTaskDuration() throws
ExecutionException, InterruptedException
}
}
- List<Map<PartitionIdType, SequenceOffsetType>> results =
Futures.successfulAsList(futures)
-
.get(futureTimeoutInSeconds, TimeUnit.SECONDS);
- for (int j = 0; j < results.size(); j++) {
- Integer groupId = futureGroupIds.get(j);
- TaskGroup group = activelyReadingTaskGroups.get(groupId);
- Map<PartitionIdType, SequenceOffsetType> endOffsets = results.get(j);
-
- if (endOffsets != null) {
- // set a timeout and put this group in pendingCompletionTaskGroups so
that it can be monitored for completion
- group.completionTimeout =
DateTimes.nowUtc().plus(ioConfig.getCompletionTimeout());
- pendingCompletionTaskGroups.computeIfAbsent(groupId, k -> new
CopyOnWriteArrayList<>()).add(group);
+ try {
+ Futures.successfulAsList(futures).get(futureTimeoutInSeconds,
TimeUnit.SECONDS);
+ }
+ finally {
+ for (int i = 0; i < futureGroupIds.size(); ++i) {
+ Integer groupId = futureGroupIds.get(i);
+ ListenableFuture<Map<PartitionIdType, SequenceOffsetType>> future =
futures.get(i);
+ if (future.isDone()) {
+ log.info("GroupId [%d] checking task finished", groupId);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
