tejaswini-imply commented on code in PR #13144:
URL: https://github.com/apache/druid/pull/13144#discussion_r988553320
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3244,6 +3275,40 @@ private void checkCurrentTaskState() throws
ExecutionException, InterruptedExcep
Futures.successfulAsList(futures).get(futureTimeoutInSeconds,
TimeUnit.SECONDS);
}
+ private void checkIfStreamInactiveAndTurnSupervisorIdle()
+ {
+ if (!spec.getSupervisorStateManagerConfig().isEnableIdleBehaviour()
+ || !spec.getIoConfig().isEnableIdleBehaviour()) {
+ return;
Review Comment:
Since if this condition turns out to be the case, It's unlikely to change
while Supervisor is running hence unlikely to be moved to Idle state. In case
of spec update or cluster restart, it would restart the Supervisor as well then
in such a scenario Idle state would be erased as well if I'm not missing
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
