AmatyaAvadhanula commented on code in PR #13144:
URL: https://github.com/apache/druid/pull/13144#discussion_r989739573
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3660,6 +3728,9 @@ protected Map<PartitionIdType, SequenceOffsetType>
getHighestCurrentOffsets()
Entry::getValue,
(v1, v2) ->
makeSequenceNumber(v1).compareTo(makeSequenceNumber(v2)) > 0 ? v1 : v2
));
+
+ partitionIds.forEach(partitionId ->
currentOffsets.putIfAbsent(partitionId,
offsetsFromMetadataStorage.get(partitionId)));
+ return currentOffsets;
}
// nothing is running but we are not suspended, so lets just hang out in
case we get called while things start up
return ImmutableMap.of();
Review Comment:
We need to return offsetsFromMetadataStorage here as well since the lag is
computed differently now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
