FrankChen021 commented on code in PR #13071:
URL: https://github.com/apache/druid/pull/13071#discussion_r990609668
##########
sql/src/main/java/org/apache/druid/sql/SqlQueryPlus.java:
##########
@@ -39,25 +39,31 @@
* SQL requests come from a variety of sources in a variety of formats. Use
* the {@link Builder} class to create an instance from the information
* available at each point in the code.
+ * <p>
+ * The query context has a complex lifecycle. The copy here should remain
+ * unchanged: this is the set of values which the user requested. Planning will
+ * add (and sometimes remove) values: that work should be done on a copy of the
+ * context so that we have a clean record of the user's original requested
+ * values.
*/
public class SqlQueryPlus
{
private final String sql;
- private final QueryContext queryContext;
+ private final Map<String, Object> queryContext;
Review Comment:
And this is immutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
