AmatyaAvadhanula commented on code in PR #13144:
URL: https://github.com/apache/druid/pull/13144#discussion_r990613026


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java:
##########
@@ -88,6 +88,9 @@ public SeekableStreamSupervisorSpec(
       @JacksonInject SupervisorStateManagerConfig supervisorStateManagerConfig
   )
   {
+    
Preconditions.checkArgument(supervisorStateManagerConfig.isEnableIdleBehaviour()
+                                || 
!ingestionSchema.getIOConfig().isEnableIdleBehaviour(),
+                                "Idle behaviour is disabled on Overlord. It 
cannot be enabled per Supervisor.");

Review Comment:
   This may break an existing supervisor's ingestion when the cluster-wide 
setting is turned off



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to