LakshSingla opened a new pull request, #13198:
URL: https://github.com/apache/druid/pull/13198
### Description
In MSQ, there can be an upper limit to the number of worker warnings. For
example, for parseExceptions encountered while parsing the external data, the
user can specify an upper limit to the number of parse exceptions that can be
allowed before it throws an error of type `TooManyWarnings`.
This PR makes it so that if the user disallows warnings of a certain type
i.e. the limit is 0 (or is executing in `strict` mode), instead of throwing an
error of type `TooManyWarnings`, we can directly surface the warning as the
error, saving the user from the hassle of going throw the warning reports.
<hr>
##### Key changed/added classes in this PR
* `ControllerImpl`
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
