LakshSingla commented on code in PR #13198:
URL: https://github.com/apache/druid/pull/13198#discussion_r991842746
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -642,12 +642,22 @@ public void updateCounters(CounterSnapshotsTree
snapshotsTree)
// Present means the warning limit was exceeded, and warnings have
therefore turned into an error.
String errorCode = warningsExceeded.get().lhs;
Long limit = warningsExceeded.get().rhs;
- workerError(MSQErrorReport.fromFault(
- id(),
- selfDruidNode.getHost(),
- null,
- new TooManyWarningsFault(limit.intValue(), errorCode)
- ));
+
+ if (limit == 0L) {
+ for (MSQErrorReport errorReport1 : workerWarnings) {
+ if
(errorReport1.getFault().getErrorCode().equalsIgnoreCase(errorCode)) {
+ workerError(errorReport1);
+ break;
+ }
+ }
Review Comment:
Makes sense, or else the controller would fail to stop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
