somu-imply commented on PR #13173: URL: https://github.com/apache/druid/pull/13173#issuecomment-1275421045
@abhishekagarwal87 I have updated the `SqlBenchmarks` with 2 additional cases which hit the new code in `DruidOuterQueryRel`. These cases have inner query with large in filters. I tested the working build (before 2022.04) and the current with the changes. Before ``` Benchmark (query) (rowsPerSegment) (vectorize) Mode Cnt Score Error Units SqlBenchmark.planSql 21 5000000 false avgt 5 2.819 ± 0.142 ms/op SqlBenchmark.planSql 22 5000000 false avgt 5 2.920 ± 0.306 ms/op ``` After ``` Benchmark (query) (rowsPerSegment) (storageType) (vectorize) Mode Cnt Score Error Units SqlBenchmark.planSql 21 5000000 mmap false avgt 5 3.261 ± 0.299 ms/op SqlBenchmark.planSql 22 5000000 mmap false avgt 5 3.215 ± 0.236 ms/op ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
