gianm commented on code in PR #13173:
URL: https://github.com/apache/druid/pull/13173#discussion_r990186903
##########
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidRules.java:
##########
@@ -223,7 +225,14 @@ public void onMatch(final RelOptRuleCall call)
.withSort(sort)
);
if (outerQueryRel.isValidDruidQuery()) {
- call.transformTo(outerQueryRel);
+ try {
+ call.transformTo(outerQueryRel);
+ }
Review Comment:
You're right to be suspicious. This change definitely isn't right. This
try/catch is papering over a bug in some implementation of DruidRel. Any
DruidRel that returns `true` from `isValidDruidQuery()` should never throw a
`CannotBuildQueryException` from either of its `toDruidQueryForExplaining` or
`toDruidQuery` methods. Instead of doing the try/catch here, the buggy DruidRel
implementation should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
