kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r994052340
##########
server/src/main/java/org/apache/druid/server/coordinator/HttpLoadQueuePeon.java:
##########
@@ -470,134 +486,98 @@ public Set<DataSegment> getSegmentsMarkedToDrop()
return Collections.unmodifiableSet(segmentsMarkedToDrop);
}
- private abstract class SegmentHolder
+ /**
+ * A request is considered to have timed out if the time elapsed since it was
+ * first sent to the server is greater than the configured load timeout.
+ *
+ * @see DruidCoordinatorConfig#getLoadTimeoutDelay()
+ */
+ private boolean hasRequestTimedOut(QueuedSegment holder)
{
- private final DataSegment segment;
- private final DataSegmentChangeRequest changeRequest;
- private final List<LoadPeonCallback> callbacks = new ArrayList<>();
-
- // Time when this request was sent to target server the first time.
- private volatile long scheduleTime = -1;
-
- private SegmentHolder(
- DataSegment segment,
- DataSegmentChangeRequest changeRequest,
- LoadPeonCallback callback
- )
- {
- this.segment = segment;
- this.changeRequest = changeRequest;
-
- if (callback != null) {
- this.callbacks.add(callback);
- }
- }
-
- public void addCallback(LoadPeonCallback newCallback)
- {
- synchronized (callbacks) {
- if (newCallback != null) {
- callbacks.add(newCallback);
- }
- }
- }
-
- public DataSegment getSegment()
- {
- return segment;
- }
-
- public DataSegmentChangeRequest getChangeRequest()
- {
- return changeRequest;
- }
-
- public boolean hasTimedOut()
- {
- if (scheduleTime < 0) {
- scheduleTime = System.currentTimeMillis();
- return false;
- } else if (System.currentTimeMillis() - scheduleTime >
config.getLoadTimeoutDelay().getMillis()) {
- return true;
- } else {
- return false;
- }
- }
+ return System.currentTimeMillis() - holder.getFirstRequestTimeMillis()
Review Comment:
Yes, that would be cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
