kfaraz commented on code in PR #13197:
URL: https://github.com/apache/druid/pull/13197#discussion_r994060186
##########
server/src/main/java/org/apache/druid/server/coordinator/BalancerStrategy.java:
##########
@@ -46,13 +46,18 @@
ServerHolder findNewSegmentHomeBalancer(DataSegment proposalSegment,
List<ServerHolder> serverHolders);
/**
- * Find the best server on which to place a {@link DataSegment} replica
according to the balancing strategy
+ * Finds the best servers on which to place a replica of the {@code
proposalSegment}
+ * according to the balancing strategy.
Review Comment:
Okay, I will try to update the javadoc to reflect this distinction. But, as
it happens, the same method is used for both "new/unavailable" segments as well
"replicating/available" segments. (this would go away if we do a round-robin
assignment in the first cycle for every segment)
So I guess the method name should just be `findSegmentHomes`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
