somu-imply commented on code in PR #13085:
URL: https://github.com/apache/druid/pull/13085#discussion_r998526989
##########
server/src/main/java/org/apache/druid/server/coordination/ServerManager.java:
##########
@@ -195,18 +194,10 @@ public <T> QueryRunner<T>
getQueryRunnerForSegments(Query<T> query, Iterable<Seg
} else {
return new
ReportTimelineMissingSegmentQueryRunner<>(Lists.newArrayList(specs));
}
+ Function<SegmentReference, SegmentReference> segmentMapFn =
analysis.getDataSource().createSegmentMapFunction(query, cpuTimeAccumulator);
Review Comment:
I get confused between use of `analysis.getDataSource()` and
`query.getDataSource()` especially when analysis is created from
`DataSourceAnalysis.fromDataSource(query.getDataSource())`. This is the case
here. I have updated it to use query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]