abhishekagarwal87 commented on code in PR #13223:
URL: https://github.com/apache/druid/pull/13223#discussion_r1005776429
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1950,6 +1950,58 @@ public Boolean
apply(SeekableStreamIndexTaskRunner.Status status)
// make sure the checkpoints are consistent with each other and with the
metadata store
verifyAndMergeCheckpoints(taskGroupsToVerify.values());
+
+ // A pause from the previous Overlord's supervisor, immediately before
leader change,
+ // can lead to tasks being in a state where they are active but do not
read.
+ resumeAllActivelyReadingTasks();
Review Comment:
how frequently is `discoverTasks` going to be called? This wouldn't just be
called after leader re-election, right? There is also code to get the status of
all tasks and then doing an action based on what the current status is. can the
resuming go inside that block of code itself? So if the status returned is
paused, only then we will be calling `resumeAsync` instead of doing it for each
task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
