AmatyaAvadhanula commented on code in PR #13223:
URL: https://github.com/apache/druid/pull/13223#discussion_r1005913009


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1950,6 +1950,58 @@ public Boolean 
apply(SeekableStreamIndexTaskRunner.Status status)
     // make sure the checkpoints are consistent with each other and with the 
metadata store
 
     verifyAndMergeCheckpoints(taskGroupsToVerify.values());
+
+    // A pause from the previous Overlord's supervisor, immediately before 
leader change,
+    // can lead to tasks being in a state where they are active but do not 
read.
+    resumeAllActivelyReadingTasks();

Review Comment:
   While discoverTasks is called in every RunNotice, there is a check within 
this method to resume only during the first run or return otherwise.
   It is called here as the pendingCompletionTaskGroups are determined here 
using the status i.e whether it is publishing or not. These tasks are not 
affected, and only the activelyReadingTaskGroups are resumed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to