clintropolis commented on code in PR #13265:
URL: https://github.com/apache/druid/pull/13265#discussion_r1006278035
##########
processing/src/main/java/org/apache/druid/segment/data/FixedIndexed.java:
##########
@@ -43,12 +44,14 @@
* If {@link #hasNull} is set, id 0 is ALWAYS null, so the comparator should
be 'nulls first' or else behavior will
* be unexpected. {@link #hasNull} can only be set if also {@link #isSorted}
is set, since the null value is not
* actually stored in the values section.
+ *
+ * This class is not thread-safe.
Review Comment:
ah i should adjust this to say this class is thread-safe if `read(ByteBuffer
buffer, int offset)` is thread-safe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
