churromorales commented on code in PR #13156:
URL: https://github.com/apache/druid/pull/13156#discussion_r1008535210
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java:
##########
@@ -927,6 +932,23 @@ public Response apply(TaskRunner taskRunner)
{
if (taskRunner instanceof WorkerTaskRunner) {
return Response.ok(((WorkerTaskRunner)
taskRunner).getWorkers()).build();
+ } else if (taskRunner.isK8sTaskRunner()) {
Review Comment:
of courser.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java:
##########
@@ -125,6 +139,69 @@ protected AbstractTask(
this(id, groupId, taskResource, dataSource, context, IngestionMode.NONE);
}
+ @Nullable
+ public String setup(TaskToolbox toolbox) throws Exception
Review Comment:
yes sir!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
