kfaraz commented on code in PR #13311:
URL: https://github.com/apache/druid/pull/13311#discussion_r1014989653
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -804,6 +805,15 @@ public SeekableStreamSupervisor(
: Math.min(10, this.ioConfig.getTaskCount() *
this.ioConfig.getReplicas()));
}
+ if (spec.getIoConfig().getIdleConfig() != null) {
+ idleConfig = spec.getIoConfig().getIdleConfig();
Review Comment:
It's possible that users have only specified enabled/disabled at the
supervisor level, but not the timeout value. Shouldn't we pick up the timeout
value defined at the cluster level then?
##########
docs/configuration/index.md:
##########
@@ -1152,7 +1152,10 @@ There are additional configs for autoscaling (if it is
enabled):
|`druid.supervisor.taskUnhealthinessThreshold`|The number of consecutive task
failures before the supervisor is considered unhealthy.|3|
|`druid.supervisor.storeStackTrace`|Whether full stack traces of supervisor
exceptions should be stored and returned by the supervisor `/status`
endpoint.|false|
|`druid.supervisor.maxStoredExceptionEvents`|The maximum number of exception
events that can be returned through the supervisor `/status`
endpoint.|`max(healthinessThreshold, unhealthinessThreshold)`|
+|`druid.supervisor.idleConfig.enabled`|If `true`, supervisor can become idle
if there is no data on input stream/topic for some time.|false|
+|`druid.supervisor.idleConfig.inactiveAfterMillis`|Supervisor is marked as
idle if all existing data has been read from input topic and no new data has
been published for `inactiveAfterMillis` milliseconds.|`600_000`|
+The `idleConfig` specified in the runtime properties of the overlord defines
the default behavior for the entire cluster. See [Idle Configuration in
`KafkaSupervisorIOConfig`](../development/extensions-core/kafka-supervisor-reference.md/#KafkaSupervisorIOConfig)
to override it for an individual supervisor.
#### Overlord Dynamic Configuration
Review Comment:
Nit: please add a newline after this before the start of the next section.
##########
website/.spelling:
##########
@@ -2285,4 +2285,4 @@ Aotearoa
Czechia
Zeelund
- ../docs/tutorials/docker.md
- nano
+ nano
Review Comment:
Please revert this change if not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
