kfaraz commented on code in PR #13311:
URL: https://github.com/apache/druid/pull/13311#discussion_r1016121948
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -804,6 +805,23 @@ public SeekableStreamSupervisor(
: Math.min(10, this.ioConfig.getTaskCount() *
this.ioConfig.getReplicas()));
}
+ IdleConfig specIdleConfig = spec.getIoConfig().getIdleConfig();
+ if (specIdleConfig != null) {
+ if (specIdleConfig.getInactiveAfterMillis() != null) {
Review Comment:
I feel we might still incorrectly handle the case where user has specified
`inactiveAfterMillis` at the supervisor level but not `enabled`. In that case,
we should just override the `inactiveAfterMillis` and take the cluster level
value for `enabled`.
But I guess that's a corner case and we can do it in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
