kfaraz commented on code in PR #13318: URL: https://github.com/apache/druid/pull/13318#discussion_r1015037777
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java: ########## @@ -188,14 +193,33 @@ public void configure(Binder binder) @Provides @LazySingleton - public Bouncer makeBouncer(final DruidProcessingConfig processingConfig, @Self final Set<NodeRole> nodeRoles) + public Bouncer makeBouncer(final DruidProcessingConfig processingConfig, Injector injector) Review Comment: In the current code, if the node roles are not set, does this `Set<NodeRole>` come out as empty or null? Can't we just use a condition on that null or emptiness instead of using `Injector`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
