rohangarg commented on code in PR #13318: URL: https://github.com/apache/druid/pull/13318#discussion_r1015740614
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQIndexingModule.java: ########## @@ -188,14 +193,33 @@ public void configure(Binder binder) @Provides @LazySingleton - public Bouncer makeBouncer(final DruidProcessingConfig processingConfig, @Self final Set<NodeRole> nodeRoles) + public Bouncer makeBouncer(final DruidProcessingConfig processingConfig, Injector injector) Review Comment: I think the `MetricsModule` change might also be obsolete after the recent refactoring in injector creation. FWIU, the module is initialized in `CoreInjectorBuilder` and that builder should have the `nodeRoleModule`. for generic solution, I was actually thinking of a way where we could always inject the node roles set from the bottom itself instead of fetching from the injector so that all extensions can just use the injection directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
