jasonk000 commented on code in PR #12302:
URL: https://github.com/apache/druid/pull/12302#discussion_r1016040822
##########
core/src/main/java/org/apache/druid/data/input/TextReader.java:
##########
@@ -55,7 +56,8 @@ public InputRowSchema getInputRowSchema()
throws IOException
{
final LineIterator delegate = new LineIterator(
- new InputStreamReader(source.open(), StringUtils.UTF8_STRING)
+ // create a small buffer, otherwise LineIterator creates a default 8KB
buffer
+ new BufferedReader(new InputStreamReader(source.open(),
StringUtils.UTF8_STRING), 256)
Review Comment:
This is a good question, I chose 256 as it's smaller and captures the
majority of the lines we ingest. It seems like something we could make
configurable. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
