clintropolis opened a new pull request, #13325:
URL: https://github.com/apache/druid/pull/13325

   ### Description
   This PR officially adds support for Parquet and Avro for Druid nested 
columns, including using the 'JSON' transformation functions at ingestion time. 
Along the way, fixes a couple of issues with using these same functions during 
ingest time, particularly when the top level object is a List/Array instead of 
an object. This particular code area was a bit obsolete, expecting only the 
primitive Druid ARRAY types to be handled, but that is no longer true after the 
introduction of nested arrays and complex expression types (e.g. arrays of 
complex types). I've expanded this code area to fall back on using 
`ExprEval.bestEffortOf` to determine the type of the array. This isn't actually 
specific to Parquet or Avro, these errors could occur with JSON and potentially 
any other nested list input values intended to be used in expressions.
   
   #### Release note
   Druid nested columns now support Parquet and Avro input formats, either to 
ingest directly into nested columns, or using the 'JSON' expressions as 
transforms, such as `JSON_VALUE` and `JSON_QUERY`.
   
   <hr>
   
   
   This PR has:
   
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [x] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to