kfaraz commented on code in PR #13328:
URL: https://github.com/apache/druid/pull/13328#discussion_r1016877728


##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3236,6 +3256,12 @@ private void checkPendingCompletionTasks()
 
   private void checkCurrentTaskState() throws ExecutionException, 
InterruptedException, TimeoutException
   {
+    List<Task> tasks = taskStorage.getActiveTasksByDatasource(dataSource);

Review Comment:
   `discoverTasks()` is followed by `updateTaskStatus()`, `checkTaskDuration()` 
and `checkPendingCompletionTasks()`. It's possible that one of them might 
update the status of these tasks thus changing the set of active tasks. So 
fetching them again here wouldn't hurt.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to