AmatyaAvadhanula commented on code in PR #13328:
URL: https://github.com/apache/druid/pull/13328#discussion_r1016894904
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3501,7 +3527,11 @@ private Map<PartitionIdType,
OrderedSequenceNumber<SequenceOffsetType>> generate
} else {
// if we don't have a startingOffset (first run or we had some
previous failures and reset the sequences) then
// get the sequence from metadata storage (if available) or
Kafka/Kinesis (otherwise)
- OrderedSequenceNumber<SequenceOffsetType> offsetFromStorage =
getOffsetFromStorageForPartition(partitionId);
+ final Map<PartitionIdType, SequenceOffsetType> metadataOffsets =
getOffsetsFromMetadataStorage();
Review Comment:
The offsets for all the partitions are fetched outside the loop and this map
is used by `getOffsetFromStorageForPartition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
