kfaraz commented on code in PR #13328:
URL: https://github.com/apache/druid/pull/13328#discussion_r1017402081
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3863,6 +3891,17 @@ public void setPartitionIdsForTests(
partitionIds.addAll(partitionIdsForTests);
}
+ @VisibleForTesting
+ public Map<String, Task> createActiveTaskMap(List<Task> tasks)
+ {
+ Map<String, Task> taskMap = new HashMap<>();
Review Comment:
Couple of suggestions here:
- do the `taskStorage.getActiveTasks()` call inside this method. Otherwise,
this method is just converting the list to a map.
- return an immutable map from here
- perhaps rename it to `getActiveTasksMap` rather than `create...`
- keep this method private as there is hardly anything to test here. It will
be tested via the other methods anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
