clintropolis opened a new pull request, #13332:
URL: https://github.com/apache/druid/pull/13332
### Description
Fixes some bugs with the `complex_decode_base64` function, which was
basically broken before this PR for a few reasons, and migrates it to being
implemented as an `ExprMacro` instead of a `Function`, so that the literal
arguments can be computed externally to the function instead of every
evaluation. This involves a slight adjustment to `ExprMacroTable` to add the
concept of built-ins to make it a bit easier to add macros.
This PR also wires `complex_decode_base64` up to SQL, previously it was only
a native expression. I have purposefully still not documented this function yet
to save room for future adjustments and determining the best way to position
this functionality, since its use cases are currently a bit limited.
The improvements do allow some pretty funny/absurd things to work now, such
as round-tripping complex types through JSON serialization and back into
complex types all in the same expression as show in one of the tests added:
```
SELECT
APPROX_COUNT_DISTINCT_BUILTIN(COMPLEX_DECODE_BASE64('hyperUnique',PARSE_JSON(TO_JSON_STRING(unique_dim1))))
from druid.foo
```
😜
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
