rohangarg commented on code in PR #13332:
URL: https://github.com/apache/druid/pull/13332#discussion_r1018469322
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/BuiltinApproxCountDistinctSqlAggregator.java:
##########
@@ -121,13 +121,22 @@ public Aggregation toDruidAggregation(
dimensionSpec = new DefaultDimensionSpec(virtualColumnName, null,
inputType);
}
- aggregatorFactory = new CardinalityAggregatorFactory(
- aggregatorName,
- null,
- ImmutableList.of(dimensionSpec),
- false,
- true
- );
+ if (HyperUniquesAggregatorFactory.TYPE.equals(inputType)) {
Review Comment:
same as for HLL sketch
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchBaseSqlAggregator.java:
##########
@@ -160,14 +161,25 @@ public Aggregation toDruidAggregation(
dimensionSpec = new DefaultDimensionSpec(virtualColumnName, null,
inputType);
}
- aggregatorFactory = new HllSketchBuildAggregatorFactory(
- aggregatorName,
- dimensionSpec.getDimension(),
- logK,
- tgtHllType,
- finalizeSketch ||
SketchQueryContext.isFinalizeOuterSketches(plannerContext),
- ROUND
- );
+ if (HllSketchModule.TYPE_NAME.equals(inputType.getComplexTypeName())) {
Review Comment:
this needs to handle `MERGE_TYPE_NAME` as well
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/ComplexDecodeBase64OperatorConversion.java:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.sql.calcite.expression.builtin;
+
+import org.apache.calcite.rex.RexNode;
+import org.apache.calcite.sql.SqlFunction;
+import org.apache.calcite.sql.SqlFunctionCategory;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.type.OperandTypes;
+import org.apache.calcite.sql.type.SqlReturnTypeInference;
+import org.apache.calcite.sql.type.SqlTypeFamily;
+import org.apache.druid.java.util.common.StringUtils;
+import org.apache.druid.math.expr.BuiltInExprMacros;
+import org.apache.druid.segment.column.ColumnType;
+import org.apache.druid.segment.column.RowSignature;
+import org.apache.druid.sql.calcite.expression.DruidExpression;
+import org.apache.druid.sql.calcite.expression.OperatorConversions;
+import org.apache.druid.sql.calcite.expression.SqlOperatorConversion;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
+import org.apache.druid.sql.calcite.table.RowSignatures;
+
+import javax.annotation.Nullable;
+
+public class ComplexDecodeBase64OperatorConversion implements
SqlOperatorConversion
+{
+
+ public static final SqlReturnTypeInference
ARBITRARY_COMPLEX_RETURN_TYPE_INFERENCE = opBinding -> {
+ String typeName = opBinding.getOperandLiteralValue(0, String.class);
+ return RowSignatures.makeComplexType(
+ opBinding.getTypeFactory(),
+ ColumnType.ofComplex(typeName),
+ true
+ );
+ };
+
+ private static final SqlFunction SQL_FUNCTION = OperatorConversions
+
.operatorBuilder(StringUtils.toUpperCase(BuiltInExprMacros.ComplexDecodeBase64ExprMacro.NAME))
+ .operandTypeChecker(
+ OperandTypes.sequence(
+ "(typeName,base64)",
+ OperandTypes.and(OperandTypes.family(SqlTypeFamily.STRING),
OperandTypes.LITERAL),
+ OperandTypes.ANY
+ )
+ )
+ .returnTypeInference(ARBITRARY_COMPLEX_RETURN_TYPE_INFERENCE)
+ .functionCategory(SqlFunctionCategory.USER_DEFINED_FUNCTION)
+ .build();
+
+
+ @Override
+ public SqlOperator calciteOperator()
+ {
+ return SQL_FUNCTION;
+ }
+
+ @Nullable
+ @Override
+ public DruidExpression toDruidExpression(
+ PlannerContext plannerContext,
+ RowSignature rowSignature,
+ RexNode rexNode
+ )
+ {
+ return OperatorConversions.convertCall(
+ plannerContext,
+ rowSignature,
+ rexNode,
+ druidExpressions -> {
+ String arg0 = druidExpressions.get(0).getExpression();
+ return DruidExpression.ofExpression(
+ ColumnType.ofComplex(arg0.substring(1, arg0.length() - 1)),
Review Comment:
probably this lambda input should be name `arguments`? also, why do we need
to do this substring extraction? sorry couldn't figure that out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
